RE: [PATCH bpf-next v2 06/11] bpf, sockmap: Don't set up sockmap progs for listening sockets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Sitnicki wrote:
> Now that sockmap can hold listening sockets, when setting up the psock we
> will (i) grab references to verdict/parser progs, and (2) override socket
> upcalls sk_data_ready and sk_write_space.
> 
> We cannot redirect to listening sockets so we don't need to link the socket
> to the BPF progs, but more importantly we don't want the listening socket
> to have overridden upcalls because they would get inherited by child
> sockets cloned from it.
> 
> Introduce a separate initialization path for listening sockets that does
> not change the upcalls and ignores the BPF progs.
> 
> Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> ---
>  net/core/sock_map.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)


Any reason only support for sock_map types are added? We can also support
sock_hash I presume? Could be a follow up patch I guess but if its not
too much trouble would be worth adding now vs trying to detect at run
time later. I think it should be as simple as using similar logic as
below in sock_hash_update_common

Thanks.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux