Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> writes: > After the series "XSk buff on a diet" by Maciej, the greatest pow-2 > which &xdp_buff_xsk can be divided got reduced from 16 to 8 on x86_64. > Also, sizeof(xdp_buff_xsk) now is 120 bytes, which, taking the previous > sentence into account, leads to that it leaves 8 bytes at the end of > cacheline, which means an array of buffs will have its elements > messed between the cachelines chaotically. > Use __aligned_largest for this struct. This alignment is usually 16 > bytes, which makes it fill two full cachelines and align an array > nicely. ___cacheline_aligned may be excessive here, especially on > arches with 128-256 byte CLs, as well as 32-bit arches (76 -> 96 > bytes on MIPS32R2), while not doing better than _largest. > > Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> Ohh, didn't know about that attribute - neat! Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
