Re: [PATCH bpf] bpftool: Fix printing incorrect pointer in btf_dump_ptr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2020-01-10 15:16 UTC-0800 ~ Martin KaFai Lau <kafai@xxxxxx>
> For plain text output, it incorrectly prints the pointer value
> "void *data".  The "void *data" is actually pointing to memory that
> contains a bpf-map's value.  The intention is to print the content of
> the bpf-map's value instead of printing the pointer pointing to the
> bpf-map's value.
> 
> In this case, a member of the bpf-map's value is a pointer type.
> Thus, it should print the "*(void **)data".
> 
> Fixes: 22c349e8db89 ("tools: bpftool: fix format strings and arguments for jsonw_printf()")
> Cc: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>
> Signed-off-by: Martin KaFai Lau <kafai@xxxxxx>

My bad, thank you for the fix!

Reviewed-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux