John Fastabend wrote: > Song Liu wrote: > > On Wed, Jan 8, 2020 at 1:17 PM John Fastabend <john.fastabend@xxxxxxxxx> wrote: > > > > > > When passed a zero length skmsg tls_push_record() causes a NULL ptr > > > deref. To resolve for fixes do a simple length check at start of > > > routine. > > > > Could you please include the stack dump for the NULL deref? > > > > Thanks, > > Song > > Sure I'll send a v2 with the stack dump. Hi Song, I'm having a bit of trouble reproducing this now. I'm going to drop this patch from the series for now and see if something changed in crypto layers or elsewhere. I originally saw this on a bit older kernel so something might changed. Feels a bit like a work-around anyways so I'll dig into it a bit more. Either way I'll try and understand this a bit better. Thanks for the question.