On Thu, 28 Nov 2024 at 00:01, Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> wrote: > > Andrii spotted that process_dynptr_func's rejection of incorrect > argument register type will print an error string where argument numbers > are not zero-indexed, unlike elsewhere in the verifier. Fix this by > subtracting 1 from regno. The same scenario exists for iterator > messages. Fix selftest error strings that match on the exact argument > number while we're at it to ensure clean bisection. > > Suggested-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> > -- When working on this, I noticed the same situation exists in IRQ save/restore v4. There are several options: 1. If this lands after IRQ series, I can respin and fix regno use in process_irq_flag. 2. Maintainer landing IRQ series can s/regno/regno - 1/ in process_irq_flag, selftests don't match on argument number. 3. I can respin IRQ series v5 with this addressed now. 4. If this lands before IRQ series, I can respin IRQ series and make the fix. 5. It can be a follow up for IRQ series. Let me know whichever seems better.
