On 11/26/24 21:47, Dmitry Torokhov wrote:
On Tue, Nov 26, 2024 at 10:13:43AM -0800, Linus Torvalds wrote:
On Tue, 26 Nov 2024 at 00:46, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
Using that (old) form results in:
error: control reaches end of non-void function [-Werror=return-type]
Ahh. Annoying, but yeah.
Except of course, now we get that dangling-else warning, there is no
winning this :-/
Well, was there any actual problem with the "jump backwards" version?
Przemek implied some problem, but ..
No, it was based on my feedback with "jump backwards" looking confusing
to me. But if it gets rid of a warning then we should use it instead.
Thanks.
yeah, no problem per-se, just "a better" choice given properly formatted
code :|, will turn it the other way, to have less surprises for those
not stressing about such aesthetic all the time ;)
--
BTW shadowing of the goto-label is not a -Wshadow but a -Wfckoff level
of complain; I have spend a few days to think of something better,
including abusing of switch and more ugly things, -ENOIDEA
