Re: [PATCH bpf 1/1] net: bpf: don't leak time wait and request sockets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH bpf 1/1] net: bpf: don't leak time wait and request sockets
From: Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
Date: Fri, 10 Jan 2020 13:27:19 +0000
Cc: Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Joe Stringer <joe@xxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "bpf@xxxxxxxxxxxxxxx" <bpf@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "kernel-team@xxxxxxxxxxxxxx" <kernel-team@xxxxxxxxxxxxxx>, "edumazet@xxxxxxxxxx" <edumazet@xxxxxxxxxx>
In-reply-to: <20200109182335.um72tp73krvvubnl@kafai-mbp.dhcp.thefacebook.com>

On Thu, 9 Jan 2020 at 18:23, Martin Lau <kafai@xxxxxx> wrote:
>
> Would this work too?
>         if (!sk_fullsock(sk) || !sock_flag(sk, SOCK_RCU_FREE))

Thank you for the suggestion, this makes the patch much nicer.

-- 
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com

References:
- [PATCH bpf 0/1] Fix memory leak in helpers dealing with sockets
  - From: Lorenz Bauer
- [PATCH bpf 1/1] net: bpf: don't leak time wait and request sockets
  - From: Lorenz Bauer
- Re: [PATCH bpf 1/1] net: bpf: don't leak time wait and request sockets
  - From: Martin Lau

Prev by Date: Re: [PATCH v16 0/5] BPF: New helper to obtain namespace data from current task
Next by Date: Re: [bpf PATCH 3/9] bpf: sockmap/tls, push write_space updates through ulp updates
Previous by thread: Re: [PATCH bpf 1/1] net: bpf: don't leak time wait and request sockets
Next by thread: [PATCH bpf v2] net: bpf: don't leak time wait and request sockets
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]