2024-11-21 11:42 UTC+0000 ~ Quentin Monnet <qmo@xxxxxxxxxx> > 2024-11-21 16:47 UTC+0800 ~ liujing <liujing@xxxxxxxxxxxxxxxxxxxx> >> From: liujing <liujing_yewu@xxxxxxxxxxxxxxxxxxxx> >> >> %d in format string requires 'int' but the argument type >> of pf is 'unsigned int'. >> >> Signed-off-by: liujing <liujing@xxxxxxxxxxxxxxxxxxxx> >> >> diff --git a/tools/bpf/bpftool/link.c b/tools/bpf/bpftool/link.c >> index 5cd503b763d7..5bc442d93456 100644 >> --- a/tools/bpf/bpftool/link.c >> +++ b/tools/bpf/bpftool/link.c >> @@ -699,7 +699,7 @@ void netfilter_dump_plain(const struct bpf_link_info *info) >> if (pfname) >> printf("\n\t%s", pfname); >> else >> - printf("\n\tpf: %d", pf); >> + printf("\n\tpf: %u", pf); >> >> if (hookname) >> printf(" %s", hookname); > > > Thanks, but while at it can you also fix the format specifier for the > other two prints of "lines" in the function (via "p_err()"), please? Apologies, I got confused between your two patches when replying. Please disregard the above for this patch, it looks good as it is. Quentin