Hi, On 11/19/2024 1:46 AM, Daniel Borkmann wrote: > Hi Hou, > > On 11/18/24 2:08 AM, Hou Tao wrote: >> From: Hou Tao <houtao1@xxxxxxxxxx> >> >> Add more test cases for LPM trie in test_maps: >> >> 1) test_lpm_trie_update_flags() >> It constructs various use cases for BPF_EXIST and BPF_NOEXIST and check >> whether the return value of update operation is expected. >> 2) test_lpm_trie_reuse_leaf_node >> It tests whether the reuse of leaf node as intermediate node is handled >> correctly when freeing the intermediate node. >> 3) test_lpm_trie_iterate_strs & test_lpm_trie_iterate_ints >> There two test case test whether the iteration through get_next_key is >> sorted and expected. These two test cases delete the minimal key after >> each iteration and check whether next iteration returns the second >> minimal key. The only difference between these two test cases is the >> former one saves strings in the LPM trie and the latter saves integers. > > Just to clarify, the added tests in 3) exercise the fix in patch 5, > correct? Yes. Sorry for failing to mention it in the commit message. Will update the commit message accordingly in next revision. > > Thanks, > Daniel
