On Wed, Nov 6, 2024 at 2:49 PM Juntong Deng <juntong.deng@xxxxxxxxxxx> wrote: > [...] > > > > CRIB is just one of possible applications of such kfuncs, so I'd steer > > away from over-specifying it as CRIB. > > > > task_file open-coded iterator is generic, and should stay close to > > other task iterator code, as you do in this revision. > > > > bpf_get_file_ops_type() is unnecessary, as we already discussed on v2, > > __ksym and comparison is the way to go here. > > > > bpf_fget_task(), if VFS folks agree to add it, probably will have to > > stay close to other similar VFS helpers. > > > > Yes, I agree. > > Maybe we should put it in fs/bpf_fs_kfuncs.c? fs/bpf_fs_kfuncs.c is a good place for bpf_fget_task(). Please note that currently all kfuncs in fs/bpf_fs_kfuncs.c are only available to BPF LSM programs. We need to make some of them, including bpf_fget_task, available to tracing functions. Thanks, Song
