From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> Date: Fri, 01 Nov 2024 14:18:04 +0100 > Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> writes: > >> The code which builds an skb from an &xdp_buff keeps multiplying itself >> around the drivers with almost no changes. Let's try to stop that by >> adding a generic function. >> There's __xdp_build_skb_from_frame() already, so just convert it to take >> &xdp_buff instead, while making the original one a wrapper. > > This does not seem to be what the patch actually does? :) Good catch. Initially, I wanted the common function to take &xdp_buff, so that frame -> skb conversion would convert frame to a buff and then call it. But there were some functional differences and also +56 bytes on the stack, so I ended up just introducing a standalone function w/o changing any existing ones. > > -Toke Thanks, Olek
