On Wed, 30 Oct 2024 16:18:55 +0000 zijianzhang@xxxxxxxxxxxxx wrote: > As the introduction of the support for vsock and unix sockets in sockmap, > tls_sw_has_ctx_tx/rx cannot presume the socket passed in must be IS_ICSK. > vsock and af_unix sockets have vsock_sock and unix_sock instead of > inet_connection_sock. For these sockets, tls_get_ctx may return an invalid > pointer and cause page fault in function tls_sw_ctx_rx. Since it's touching TLS code: Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx> I wonder if we should move these helpers to skmsg or such, since only bpf uses them.