On Sat, Nov 2, 2024 at 9:44 PM Simon Horman <horms@xxxxxxxxxx> wrote: > > On Mon, Oct 28, 2024 at 07:05:23PM +0800, Jason Xing wrote: > > From: Jason Xing <kernelxing@xxxxxxxxxxx> > > > > This patch has introduced a separate sk_tsflags_bpf for bpf > > extension, which helps us let two feature work nearly at the > > same time. > > > > Each feature will finally take effect on skb_shinfo(skb)->tx_flags, > > say, tcp_tx_timestamp() for TCP or skb_setup_tx_timestamp() for > > other types, so in __skb_tstamp_tx() we are unable to know which > > feature is turned on, unless we check each feature's own socket > > flag field. > > > > Signed-off-by: Jason Xing <kernelxing@xxxxxxxxxxx> > > --- > > include/net/sock.h | 1 + > > net/core/skbuff.c | 39 +++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 40 insertions(+) > > > > diff --git a/include/net/sock.h b/include/net/sock.h > > index 7464e9f9f47c..5384f1e49f5c 100644 > > --- a/include/net/sock.h > > +++ b/include/net/sock.h > > @@ -445,6 +445,7 @@ struct sock { > > u32 sk_reserved_mem; > > int sk_forward_alloc; > > u32 sk_tsflags; > > + u32 sk_tsflags_bpf; > > Please add sk_tsflags_bpf to the Kernel doc for this structure. > Likewise for sk_tskey_bpf_offset which is added by a subsequent patch. Oh, thanks for reminding me!