Song Liu <songliubraving@xxxxxx> [Wed, 2020-01-08 08:31 -0800]:
[...]
> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > index 7df436da542d..dc4b8a2d2a86 100644
> > --- a/include/uapi/linux/bpf.h
> > +++ b/include/uapi/linux/bpf.h
> > @@ -357,7 +357,12 @@ enum bpf_attach_type {
> > /* Enable memory-mapping BPF map */
> > #define BPF_F_MMAPABLE (1U << 10)
> >
> > -/* flags for BPF_PROG_QUERY */
> > +/* Flags for BPF_PROG_QUERY. */
> > +
> > +/* Query effective (directly attached + inherited from ancestor cgroups)
> > + * programs that will be executed for events within a cgroup.
> > + * attach_flags with this flag are returned only for directly attached programs.
>
> This line is more than 75 byte long, I guess ./scripts/checkpatch.pl would
> complain about it?
I run checkpatch.pl before sending it but it didn't complain:
% scripts/checkpatch.pl p/0001-bpf-Document-BPF_F_QUERY_EFFECTIVE-flag.patch
total: 0 errors, 0 warnings, 26 lines checked
p/0001-bpf-Document-BPF_F_QUERY_EFFECTIVE-flag.patch has no obvious style problems and is ready for submission.
I haven't debugged why, but this header has plenty of lines like this:
% awk 'length($0) >= 75' include/uapi/linux/bpf.h | wc -l
74
--
Andrey Ignatov
