On 10/31/24 9:39 AM, Stanislav Fomichev wrote:
On 10/30, Zijian Zhang wrote:
On 10/30/24 8:38 AM, Stanislav Fomichev wrote:
Thanks for the Ack and reviewing!
In order to make it more accurate, I added inet_test_bit(IS_ICSK, sk)
check in version2. I just found that sk_is_inet only cannot assure
inet_csk is valid. For example, udp_sock does not have inet_connection_sock.
Instead of testing IS_ICSK bit, will inet_csk_has_ulp helper work?
Nice catch, while testing IS_ICSK bit is sufficient, inet_csk_has_ulp is
a stricter check. I am good with either approach.
