> On Oct 29, 2024, at 5:11 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Oct 29, 2024 at 04:12:41PM -0700, Song Liu wrote: >> + if (strstr(file_name->name, item->prefix) == (char *)file_name->name) > > Huh? "Find the first substring (if any) equal to item->prefix and > then check if that happens to be in the very beginning"??? Replaced it with strcmp locally, assuming strncmp is not necessary. > > And you are placing that into the place where it's most likely to cause > the maximal braindamage and spread all over the tree. Wonderful ;-/ > > Where does that "idiom" come from, anyway? Java? Not the first time > I see that kind of garbage; typecast is an unusual twist, though... The strstr() was probably from lack of coffee. The cast is most likely from the compiler yelling at sleepy me. BTW: Why do we need "const unsigned char *" in qstr instead of "const char *"? I do notice git doesn't show the real history of it.. Thanks, Song
