Forrest Chen wrote: > Thanks John for the review. Usually try not to top post. > > I think you are right for the missing part. I would like to update the > patch and re-send it, is it ok for you? Yep glad to have more folks looking over sockmap code and looks like it already hit the list so that is good. > > Since it is my first kernel patch, I'm not familiar with the process. > What''s the meaning of 'add your Signed-off-by'? > I think I have add Signed-off-by in the first patch, do you mean I should > add 'Signed-off-by: John Fastabend <john.fastabend@xxxxxxxxx>' as well? > I was just saying feel free to add _your_ Signed-off-by to the patch I attached and send it. You added my signed-off-by to your patch which is also fine I don't think it matters much as long as we get the fix. Also we should add Fixes tag and a tag to give Arika some credit. Seems we had the same fix in mind. I'll just add those now, next time for fixes please add a Fixes tag so we can track where we need to backport the fix. Thanks for looking into this.
