Re: [PATCH bpf-next v2 1/2] bpf: add bpf_get_hw_counter kfunc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2024-10-24 at 15:28 -0700, Alexei Starovoitov wrote:

[...]

> > call->imm is BTF id, call->off is ID of the BTF itself.
> 
> it's actually offset in fd_array

Sure.

> > I asked Vadim to add this check to make sure that imm points to the
> > kernel BTF.
> 
> makes sense.
> 
> is_fastcall_kfunc_call(&meta) && meta.btf == btf_vmlinux && ..
> 
> would have been much more obvious.

Yes, this one looks better.






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux