On Mon, 2024-10-21 at 13:14 -0700, Andrii Nakryiko wrote: > On Mon, Oct 21, 2024 at 9:44 AM Jiri Olsa <olsajiri@xxxxxxxxx> wrote: [...] > > IIUC this would try to use 1GB by default? seems to agresive.. could we perhaps > > do that gradually and double the size on each failed load attempt? > > The idea is that verifier will only page in as many pages as there is > an actual log content (which normally would be much smaller than a > full 1GB). Doing gradual size increase is actually pretty annoying in > terms of how the code and logic is structured. So I think this > approach is fine, overall. As far as I understand, this feature is most useful for programs that are close to 1M instructions limit. Such programs easily produce huge logs. E.g. selftest pyperf600.bpf.o takes 627,288 instructions to verify and generates 281MB of log. I agree with Andrii, that allocating 1G for this purpose seems reasonable. [...]
