On Sun, 20 Oct 2024 at 22:51, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx> wrote: > > Stanislav Fomichev wrote: > > On 10/18, Muyang Tian wrote: > > > This series introduce XDP metadata functionality, including Rx checksum/GSO hint > > > and Tx GSO offload. This is aimed to transfer control fields when processing jumbo > > > frames between VMs. > > > > Ideally, the series should also have the implementation of these hints > > for a couple of devices and appropriate selftest updates to exercise > > them. > > +1 Larysa had one implementation for ice [0]. Ask her if she can update and contribute that one. Then add one yourself and there are two implementations which would hopefully make the case. [0] https://lore.kernel.org/bpf/20230811161509.19722-1-larysa.zaremba@xxxxxxxxx/ > > For GSO, CC Willem going forward (I don't think I understand why > > we want to have gso_type in the TX hint; something like header_len > > seems like a better fit). > > GSO on Tx makes sense. To be able to program hardware USO, say. > > GSO on Rx is less obvious. Is this for HW-GRO? In general, some usage > context will be helpful. > > Two implementation questions: > > - why define an XDP specific type for checksum types, but reuse the > netdev type for gso_type? > - why u32 gso_type, when it is a u8 in skb_shared_info? > > > Please also don't post v3 yet and allow at least a week for the initial > > reviewers to catch up.. > > >
