On 10/15/24 16:07, Menglong Dong wrote:
> @@ -352,6 +353,28 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
> struct flowi4 fl4;
> bool dev_match;
>
> + /* Ignore rp_filter for packets protected by IPsec. */
> + if (!rpf && !fib_num_tclassid_users(net) &&
> + (dev->ifindex != oif || !IN_DEV_TX_REDIRECTS(idev))) {
> + if (IN_DEV_ACCEPT_LOCAL(idev))
> + goto last_resort;
IMHO the re-usage of the 'last_resort' macro makes the patch a little
hard to read, as this is an 'accept' condition. I think it would be
better to retain the original code. If you really want to avoid the
small duplication, you could instead introduce an 'ok' label towards the
end of this function:
last_resort:
if (rpf)
goto e_rpf;
ok:
*itag = 0;
return 0;
And jump there.
Thanks,
Paolo
