On Thu, Oct 10, 2024 at 4:30 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote: > > On 10/7/24 09:46, Menglong Dong wrote: > > In this series, we mainly add some skb drop reasons to the input path of > > ip routing. > > > > The errno from fib_validate_source() is -EINVAL or -EXDEV, and -EXDEV is > > used in ip_rcv_finish_core() to increase the LINUX_MIB_IPRPFILTER. For > > this case, we can check it by > > "drop_reason == SKB_DROP_REASON_IP_RPFILTER" instead. Therefore, we can > > make fib_validate_source() return -reason. > > > > Meanwhile, we make the following functions return drop reasons too: > > > > ip_route_input_mc() > > ip_mc_validate_source() > > ip_route_input_slow() > > ip_route_input_rcu() > > ip_route_input_noref() > > ip_route_input() > > A few other functions are excluded, so that the ip input path coverage > is not completed - i.e. ip_route_use_hint(), is that intentional? > Hello, That's not intentional, I just missed them. At the beginning, I wanted to organize the drop reasons in ip_route_input_noref(), and things become complex when I do it. Let me have a check and make the coverage complete. > In any case does not apply cleanly anymore. > > Please answer to the above question and question on patch 1 before > submitting a new revision. At very least the new revision should include > a comment explaining the reasoning for the current choice. > > Please, include in each patch the detailed changelog after the '---' > separator. > Sorry about that. I thought the patches for ip_route_input_noref, ip_route_input_rcu, ip_route_input_slow are completely new one, and abandoned the changelogs in the patches. I'll complete the changelogs in the next version. Thanks! Menglong Dong > Thanks, > > Paolo >
