Re: [PATCH bpf 0/4] bpf, vsock: Fixes related to sockmap/sockhash redirection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 09, 2024 at 11:20:49PM GMT, Michal Luczaj wrote:
Series consists of few fixes for issues uncovered while working on a BPF
sockmap/sockhash redirection selftest.

The last patch is more of a RFC clean up attempt. Patch claims that there's
no functional change, but effectively it removes (never touched?) reference
to sock_map_unhash().

I'm not an expert on BPF, so I reviewed only those that touch virtio-vsock.

I only have a doubt about another call to add, otherwise LGTM.

I think we should handle the two receive paths better, so in the future we should refactor the code a bit to avoid this difference. I'll try to take a look at it in the coming weeks, but for now let's get on with this series.

Thanks,
Stefano


Signed-off-by: Michal Luczaj <mhal@xxxxxxx>
---
Michal Luczaj (4):
     bpf, sockmap: SK_DROP on attempted redirects of unsupported af_vsock
     vsock: Update rx_bytes on read_skb()
     vsock: Update msg_count on read_skb()
     bpf, vsock: Drop static vsock_bpf_prot initialization

include/net/sock.h                      |  5 +++++
net/core/sock_map.c                     |  8 ++++++++
net/vmw_vsock/virtio_transport_common.c | 14 +++++++++++---
net/vmw_vsock/vsock_bpf.c               |  8 --------
4 files changed, 24 insertions(+), 11 deletions(-)
---
base-commit: 94e354adf6c210ce79827f5affb0cf69f380d181
change-id: 20241009-vsock-fixes-for-redir-86707e1e8c04

Best regards,
--
Michal Luczaj <mhal@xxxxxxx>






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux