On Wed, Oct 2, 2024 at 7:32 AM Jason Xing <kerneljasonxing@xxxxxxxxx> wrote: > > From: Jason Xing <kernelxing@xxxxxxxxxxx> > > In some environments (gcc treated as error in W=1, which is default), if we > make -C samples/bpf/, it will be stopped because of > "no previous prototype" error like this: > > ../samples/bpf/syscall_nrs.c:7:6: > error: no previous prototype for ‘syscall_defines’ [-Werror=missing-prototypes] > void syscall_defines(void) > ^~~~~~~~~~~~~~~ > > Actually, this file meets our expectatations because it will be converted to > a .h file. In this way, it's correct. Considering the warnning stopping us > compiling, we can remove the warnning directly. > > Signed-off-by: Jason Xing <kernelxing@xxxxxxxxxxx> Hello Andrii, Could you help me review this version? Thanks, Jason