On Fri, 2024-09-27 at 15:31 -0700, Andrii Nakryiko wrote:
[...]
> @@ -871,9 +871,10 @@ class PrinterHelpers(Printer):
> print(' *{}{}'.format(' \t' if line else '', line))
>
> print(' */')
> + print('static ', end='')
> if helper.attrs:
> - print(" ".join(helper.attrs))
> - print('static %s %s(* const %s)(' % (self.map_type(proto['ret_type']),
> + print('%s ' % (" ".join(helper.attrs)), end='')
> + print('%s %s(* const %s)(' % (self.map_type(proto['ret_type']),
> proto['ret_star'],
> proto['name']), end='')
> comma = ''
> for i, a in enumerate(proto['args']):
>
> But now I have:
>
> static __bpf_fastcall __u32 (* const bpf_get_smp_processor_id)(void) =
> (void *) 8;
>
> and
>
> extern __bpf_fastcall void *bpf_rdonly_cast(const void *obj__ign, u32
> btf_id__k) __weak __ksym;
>
> and that makes me a touch happier. I hope you don't mind.
This change looks fine to me.
[...]
> Looks good to me, and I'm not sure there is anything too controversial
> here, so I went ahead and applied to bpf-next, thanks.
Great, thank you.
