> -----Original Message----- > From: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx> > Sent: 2024年9月23日 13:03 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; Claudiu Manoil <claudiu.manoil@xxxxxxx>; Vladimir > Oltean <vladimir.oltean@xxxxxxx>; ast@xxxxxxxxxx; daniel@xxxxxxxxxxxxx; > hawk@xxxxxxxxxx; john.fastabend@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; > imx@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net 1/3] net: enetc: remove xdp_drops statistic from > enetc_xdp_drop() > > On 2024-09-19 at 14:11:02, Wei Fang (wei.fang@xxxxxxx) wrote: > > The xdp_drops statistic indicates the number of XDP frames dropped in > > the Rx direction. However, enetc_xdp_drop() is also used in XDP_TX and > > XDP_REDIRECT actions. If frame loss occurs in these two actions, the > > frames loss count should not be included in xdp_drops, because there > > are already xdp_tx_drops and xdp_redirect_failures to count the frame > > loss of these two actions, so it's better to remove xdp_drops statistic > > from enetc_xdp_drop() and increase xdp_drops in XDP_DROP action. > nit: s/xdp_drops/xdp_rx_drops would be appropriate as you have > xdp_tx_drops and > xdp_redirect_failures. Sorry, I don't quite understand what you mean.
