Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 20, 2019 at 09:44:42AM -0800, Andrii Nakryiko wrote:
> On Fri, Dec 20, 2019 at 8:19 AM Jesper Dangaard Brouer
> <brouer@xxxxxxxxxx> wrote:
> >
> > When sample xdp_redirect_cpu was converted to use libbpf, the
> > tracepoints used by this sample were not getting attached automatically
> > like with bpf_load.c. The BPF-maps was still getting loaded, thus
> > nobody notice that the tracepoints were not updating these maps.
> >
> > This fix doesn't use the new skeleton code, as this bug was introduced
> > in v5.1 and stable might want to backport this. E.g. Red Hat QA uses
> > this sample as part of their testing.
> >
> > Fixes: bbaf6029c49c ("samples/bpf: Convert XDP samples to libbpf usage")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> > ---
> 
> Acked-by: Andrii Nakryiko <andriin@xxxxxx>

Applied to bpf-next. Thanks



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux