On Thu, Sep 12, 2024 at 10:17:13PM +0200, Alexis Lothoré wrote: > Hi Simon, > > On 9/11/24 16:18, Simon Horman wrote: > > [...] > > >> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_features.c b/tools/testing/selftests/bpf/prog_tests/xdp_features.c > >> new file mode 100644 > >> index 000000000000..bcb36a2d2767 > >> --- /dev/null > >> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_features.c > >> @@ -0,0 +1,446 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> + > >> +/** > >> + * Test XDP features > >> + * > >> + * Sets up a veth pair, and for each xdp feature under test: > >> + * - asks the tested interface its xdp capabilities through bpf_xdp_query > >> + * - attach and run some specific programs on both interfaces to check if > >> + * announced capability is respected > >> + */ > > > > Hi Alexis, > > > > This is neither a full review nor an issue that needs to block progress. > > But, FWIIW, the comment above is not a Kernel doc, yet starts with '/**'. > > I suggest that it should start with '/*' instead. > > ACK. I'll wait for more comments on the series, and add the fix to the > corresponding revision, if any. Thanks, much appreciated.
