Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Wed, 11 Sep 2024 06:30:53 -0400
Cc: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Eugenio Pérez <eperezma@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, virtualization@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx
In-reply-to: <CACGkMEuN6mFv2NjkA-NFBE2NCt0F1EW5Gk=X0dC4hz45Ns+jhw@mail.gmail.com>

On Wed, Sep 11, 2024 at 11:46:30AM +0800, Jason Wang wrote:
> On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx> wrote:
> >
> > 1. this commit hardens dma unmap for indirect
> 
> I think we need to explain why we need such hardening.


yes pls be more specific. Recording same state in two
places is just a source of bugs, not hardening.

References:
- [PATCH net-next 00/13] virtio-net: support AF_XDP zero copy (tx)
  - From: Xuan Zhuo
- [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
  - From: Xuan Zhuo
- Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
  - From: Jason Wang

Prev by Date: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text
Next by Date: [PATCH 1/3] btf: remove redundant CONFIG_BPF test in scripts/link-vmlinux.sh
Previous by thread: Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
Next by thread: Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]