Hi Jitendra On Tue, Sep 03, 2024 at 10:48:10PM -0700, jitendra.vegiraju@xxxxxxxxxxxx wrote: > From: Jitendra Vegiraju <jitendra.vegiraju@xxxxxxxxxxxx> > > This patchset adds basic PCI ethernet device driver support for Broadcom > BCM8958x Automotive Ethernet switch SoC devices. > > This SoC device has PCIe ethernet MAC attached to an integrated ethernet > switch using XGMII interface. The PCIe ethernet controller is presented to > the Linux host as PCI network device. > > The following block diagram gives an overview of the application. > +=================================+ > | Host CPU/Linux | > +=================================+ > || PCIe > || > +==========================================+ > | +--------------+ | > | | PCIE Endpoint| | > | | Ethernet | | > | | Controller | | > | | DMA | | > | +--------------+ | > | | MAC | BCM8958X | > | +--------------+ SoC | > | || XGMII | > | || | > | +--------------+ | > | | Ethernet | | > | | switch | | > | +--------------+ | > | || || || || | > +==========================================+ > || || || || More external interfaces > > The MAC block on BCM8958x is based on Synopsis XGMAC 4.00a core. This > MAC IP introduces new DMA architecture called Hyper-DMA for virtualization > scalability. > > Driver functionality specific to new MAC (DW25GMAC) is implemented in > new file dw25gmac.c. > > Management of integrated ethernet switch on this SoC is not handled by > the PCIe interface. > This SoC device has PCIe ethernet MAC directly attached to an integrated > ethernet switch using XGMII interface. > > v4->v5: > Summary of changes in this patch series: > As suggested by Serge Semin, defined common setup function for dw25gmac. > To accommodate early adopter DW25GMAC used in BCM8958x device, provide > a mechanism to override snps_id and snps_dev_id used for driver entry > matching in hwif.c > > Patch1: > Added plat_stmmacenet_data::snps_id,snps_dev_id fields - Serge Semin > Patch2: > Define common setup function for dw25gmac_setup() - Serge Semin > Support DW25GMAC IPs with varying VDMA/PDMA count - Abhishek Chauhan > Allocate and initialize hdma mapping configuration data dynamically > based on device's VDMA/PDMA feature capabilities in dw25gmac_setup(). > Spelling errors in commit log, lower case 0x for hex -Amit Singh Tomar > Patch3: > Glue support in hwif.c for DW25GMAC in hwif.c - Serge Semin > Provide an option to override snps_id and snps_dev_id when the device > reports version info not conformant with driver's expectations as is > the case with BCM8958x device. - Serge Semin > Patch4: > Remove setup function in the glue driver - Serge Semin > Remove unnecessary calls pci_enable_device() and pci_set_master() > in dwxgmac_brcm_pci_resume() - Jakub Kicinski > Merge variable definitions to single line - Amit Singh Tomar Thanks for the update. I'll have a closer look at the series early next week. -Serge(y) > [...]