On Wed, Sep 4, 2024 at 7:17 AM Pu Lehui <pulehui@xxxxxxxxxxxxxxx> wrote: > > From: Pu Lehui <pulehui@xxxxxxxxxx> > > The $(let ...) function is only supported by GNU Make version 4.4 [0] Eduard, seems like the mystery is finally solved. We were actually considering removing the FEATURE-DUMP functionality from BPF selftests, but it's good to have a fix nevertheless, thanks! > and above, otherwise the following exception file or directory will be > generated: > > tools/testing/selftests/bpfFEATURE-DUMP.selftests > tools/testing/selftests/bpffeature/ > > Considering that the GNU Make version of most Linux distributions is > lower than 4.4, let us adapt the corresponding logic to it. > > Link: https://lists.gnu.org/archive/html/info-gnu/2022-10/msg00008.html [0] > Signed-off-by: Pu Lehui <pulehui@xxxxxxxxxx> > --- > tools/testing/selftests/bpf/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 7660d19b66c2..9905e3739dd0 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -187,8 +187,14 @@ FEATURE_TESTS := llvm > FEATURE_DISPLAY := $(FEATURE_TESTS) > > # Makefile.feature expects OUTPUT to end with a slash > +ifeq ($(shell expr $(MAKE_VERSION) \>= 4.4), 1) > $(let OUTPUT,$(OUTPUT)/,\ > $(eval include ../../../build/Makefile.feature)) > +else > +OUTPUT := $(OUTPUT)/ > +$(eval include ../../../build/Makefile.feature) > +OUTPUT := $(patsubst %/,%,$(OUTPUT)) > +endif > endif > > ifeq ($(feature-llvm),1) > -- > 2.34.1 >
