On Wed, 4 Sep 2024 17:13:59 +0200 Alexander Lobakin wrote: > >> I could say that gro_cells also "abuses" NAPI the same way, don't you > >> think? > > > > "same way"? :] Does it allocate a fake netdev, use NAPI as a threading > > abstraction or add extra fields to napi_struct ? > > Wait wait wait, you said "NAPI IRQ related logics doesn't fit here". I > could say the same for gro_cells -- IRQ related NAPI logics doesn't fit > there. gro_cells is an SW abstraction. Yes, that 1/4th of my complaint does indeed apply :) > A fake netdev is used by multiple drivers to use GRO, you know that > (popular for wireless drivers). They also conflict with the queue config > effort. And it did cause us some issues when changing netdev_priv() already.
