> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Kurt
> Kanzenbach
> Sent: Thursday, August 22, 2024 12:42 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>
> Cc: Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; Daniel Borkmann
> <daniel@xxxxxxxxxxxxx>; Sriram Yagnaraman
> <sriram.yagnaraman@xxxxxxxxxxxx>; Sebastian Andrzej Siewior
> <bigeasy@xxxxxxxxxxxxx>; Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>; John Fastabend
> <john.fastabend@xxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Sriram
> Yagnaraman <sriram.yagnaraman@xxxxxxxx>; Benjamin Steinke
> <benjamin.steinke@xxxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; Fijalkowski, Maciej <maciej.fijalkowski@xxxxxxxxx>; intel-
> wired-lan@xxxxxxxxxxxxxxxx; Jakub Kicinski <kuba@xxxxxxxxxx>;
> bpf@xxxxxxxxxxxxxxx; Paolo Abeni <pabeni@xxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH iwl-net] igb: Always call igb_xdp_ring_update_tail()
> under Tx lock
>
> From: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx>
>
> Always call igb_xdp_ring_update_tail() under __netif_tx_lock, add a comment and
> lockdep assert to indicate that. This is needed to share the same TX ring between
> XDP, XSK and slow paths. Furthermore, the current XDP implementation is racy on
> tail updates.
>
> Fixes: 9cbc948b5a20 ("igb: add XDP support")
> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx>
> [Kurt: Add lockdep assert and fixes tag]
> Signed-off-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@xxxxxxxxx>
