On Sat, Aug 24, 2024 at 3:48 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Fri, Aug 23, 2024 at 4:00 PM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
> >
> > Do we have to catch all possibilities? Then, what about this:
>
> Something like that sounds good to me too -- we do something similar
> in `rust_is_available.sh`. We also have a `1` in the beginning of
> (most of) the `sed` commands there to check only the first line.
>
> I guess it depends on whether Masahiro thinks the extra
> checks/complexity is worth it. Here I was aiming to catch the case he
> reported, i.e. non-successful programs.
My previous report was slightly different.
CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT are string type symbols.
The shell command is allowed to return any string, including an empty string,
as long as the value is enclosed by double quotes.
In this case, CONFIG_PAHOLE_VERSION is an int type symbol,
hence the shell command must not return an empty string.
Ensuring this should be easy.
Why don't we fix it properly while we are here?
>
> Cheers,
> Miguel
>
--
Best Regards
Masahiro Yamada
