On Fri, Aug 30, 2024 at 6:19 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote: > > On Fri, Aug 30, 2024 at 11:05:30AM +0100, Alan Maguire wrote: > > On 30/08/2024 10:21, Eduard Zingerman wrote: > > > On Fri, 2024-08-30 at 02:49 +0000, Song Liu wrote: > > >> With the regression, _both_ .BTF and .BTF.base sections (or at > > >> least part of these sections) are in little endian for s390: > > > > Hi Song, > > > > Understood, thank you for clarification and sorry for confusion. > > > This makes sense because btf__distill_base() generates > > > two new BTF structures and both need to inherit endianness. > > > thanks all for the quick root-cause analysis and proposed fixes! > > Explicitly checking these cases in the btf_endian selftest is probably > > worthwhile; I've put together tests that do that for non-native > > endianness but just noticed you mentioned you're working on tests > > Eduard. Is that what you had in mind? > > > Arnaldo: apologies but I think we'll either need to back out the > > distilled stuff for 1.28 or have a new libbpf resync that captures the > > fixes for endian issues once they land. Let me know what works best for > > you. Thanks! > > It was useful, we got it tested more widely and caught this one. > > Andrii, what do you think? Can we get a 1.5.1 with this soon so that we > do a resying in pahole and then release 1.28? Did you mean 1.4.6? We haven't released v1.5 just yet. But yes, I'm going to cut a new set of bugfix releases to libbpf anyways, there is one more skeleton-related fix I have to backport. So I'll try to review, land, and backport the fix ASAP. > > - Arnaldo
