On Fri, Aug 23, 2024 at 03:48 PM -07, Yaxin Chen wrote: > Parameter flags is not used in bpf_tcp_ingress(). > > Reviewed-by: Cong Wang <cong.wang@xxxxxxxxxxxxx> > Cc: John Fastabend <john.fastabend@xxxxxxxxx> > Cc: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> > Signed-off-by: Yaxin Chen <yaxin.chen1@xxxxxxxxxxxxx> > --- First introduced in commit 8934ce2fd081 ("bpf: sockmap redirect ingress support") [1]. Looks like it was never in use from the beginning. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8934ce2fd08171e8605f7fada91ee7619fe17ab8 Acked-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>