Hi Manu,
On 21/08/2024 22:32, Manu Bretelle wrote:
>
>
>> On Aug 13, 2024, at 6:12 PM, Martin KaFai Lau <martin.lau@xxxxxxxxx> wrote:
>>
>>>
>> On 8/5/24 2:52 AM, Matthieu Baerts (NGI0) wrote:
>>> +static int endpoint_init(char *flags)
>>> +{
>>> + SYS(fail, "ip -net %s link add veth1 type veth peer name veth2", NS_TEST);
>>> + SYS(fail, "ip -net %s addr add %s/24 dev veth1", NS_TEST, ADDR_1);
>>> + SYS(fail, "ip -net %s link set dev veth1 up", NS_TEST);
>>> + SYS(fail, "ip -net %s addr add %s/24 dev veth2", NS_TEST, ADDR_2);
>>> + SYS(fail, "ip -net %s link set dev veth2 up", NS_TEST);
>>> + if (SYS_NOFAIL("ip -net %s mptcp endpoint add %s %s", NS_TEST, ADDR_2, flags)) {
>>> + printf("'ip mptcp' not supported, skip this test.\n");
>>> + test__skip();
>>
>> It is always a skip now in bpf CI:
>>
>> #171/3 mptcp/subflow:SKIP
>>
>> This test is a useful addition for the bpf CI selftest.
>>
>> It can't catch regression if it is always a skip in bpf CI though.
>>
>> iproute2 needs to be updated (cc: Daniel Xu and Manu, the outdated iproute2 is something that came up multiple times).
>>
>> Not sure when the iproute2 can be updated. In the mean time, your v3 is pretty close to getting pm_nl_ctl compiled. Is there other blocker on this?
>
> I have updated runners to Ubuntu 24.04 which comes with:
> root@1fdd5d75581b:/actions-runner# ip --json -V
> ip utility, iproute2-6.1.0, libbpf 1.3.0
> root@1fdd5d75581b:/actions-runner# ip mptcp help
> Usage: ip mptcp endpoint add ADDRESS [ dev NAME ] [ id ID ]
> [ port NR ] [ FLAG-LIST ]
> ip mptcp endpoint delete id ID [ ADDRESS ]
> ip mptcp endpoint change [ id ID ] [ ADDRESS ] [ port NR ] CHANGE-OPT
> ip mptcp endpoint show [ id ID ]
> ip mptcp endpoint flush
> ip mptcp limits set [ subflows NR ] [ add_addr_accepted NR ]
> ip mptcp limits show
> ip mptcp monitor
> FLAG-LIST := [ FLAG-LIST ] FLAG
> FLAG := [ signal | subflow | backup | fullmesh ]
> CHANGE-OPT := [ backup | nobackup | fullmesh | nofullmesh ]
>
> Assuming I don’t need to revert back to old runners due to unrelated issue, you should now have `ip mptcp` available.
Great, thank you for this update, that will ease the inclusion of this
series!
(That's a shame Ubuntu 24.04 didn't come with IPRoute 6.8, same version
as their default kernel [1]... but that's not blocking us here)
[1] https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/2051672
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
