Re: [PATCH iwl-next v6 1/6] igb: Always call igb_xdp_ring_update_tail() under Tx lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon Aug 19 2024, Maciej Fijalkowski wrote:
> On Fri, Aug 16, 2024 at 11:24:00AM +0200, Kurt Kanzenbach wrote:
>> From: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx>
>> 
>> Always call igb_xdp_ring_update_tail() under __netif_tx_lock(), add a
>> comment to indicate that. This is needed to share the same TX ring between
>> XDP, XSK and slow paths.
>
> Sorry for being a-hole here but I think this should go to -net as a fix...
> I should have brought it up earlier, current igb XDP support is racy on
> tail updates which you're fixing here.
>
> Do you agree...or not?:)

Yeah, makes sense. I'll add a Fixes tag and send it to iwl-net.

Thanks,
Kurt

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux