On Fri Aug 16 2024, Sebastian Andrzej Siewior wrote:
> On 2024-08-16 11:24:00 [+0200], Kurt Kanzenbach wrote:
>> index 11be39f435f3..4d5e5691c9bd 100644
>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>> @@ -2914,6 +2914,7 @@ static int igb_xdp(struct net_device *dev, struct netdev_bpf *xdp)
>> }
>> }
>>
>> +/* This function assumes __netif_tx_lock is held by the caller. */
>> static void igb_xdp_ring_update_tail(struct igb_ring *ring)
>> {
>> /* Force memory writes to complete before letting h/w know there
> This
> lockdep_assert_held(txring_txq(ring)->_xmit_lock);
> would be more powerful than the comment ;)
Probably yes :-).
Thanks,
Kurt
Attachment:
signature.asc
Description: PGP signature
