On Tue, Aug 13, 2024 at 4:30 AM Yunsheng Lin <linyunsheng@xxxxxxxxxx> wrote: > > On 2024/8/8 20:37, Yunsheng Lin wrote: > > ... > > > > > CC: Alexander Duyck <alexander.duyck@xxxxxxxxx> > > > > 1. https://lore.kernel.org/all/20240228093013.8263-1-linyunsheng@xxxxxxxxxx/ > > > > Change log: > > V13: > > 1. Move page_frag_test from mm/ to tools/testing/selftest/mm > > 2. Use ptr_ring to replace ptr_pool for page_frag_test.c > > 3. Retest based on the new testing ko, which shows a big different > > result than using ptr_pool. > > Hi, Davem & Jakub & Paolo > It seems the state of this patchset is changed to 'Deferred' in the > patchwork, as the info regarding the state in 'Documentation/process/ > maintainer-netdev.rst': > > Deferred patch needs to be reposted later, usually due to dependency > or because it was posted for a closed tree > > Obviously it was not the a closed tree reason here, I guess it was the dependency > reason casuing the 'Deferred' here? I am not sure if I understand what sort of > dependency this patchset is running into? It would be good to mention what need > to be done avoid the kind of dependency too. > > > Hi, Alexander > The v13 mainly address your comments about the page_fage_test module. > It seems the your main comment about this patchset is about the new API > naming now, and it seems there was no feedback in previous version for > about a week: > > https://lore.kernel.org/all/ca6be29e-ab53-4673-9624-90d41616a154@xxxxxxxxxx/ > > If there is still disagreement about the new API naming or other things, it > would be good to continue the discussion, so that we can have better > understanding of each other's main concern and better idea might come up too, > like the discussion about new layout for 'struct page_frag_cache' and the > new refactoring in patch 8. Sorry for not getting to this sooner. I have been travelling for the last week and a half. I just got home on Sunday and I am suffering from a pretty bad bout of jet lag as I am overcoming a 12.5 hour time change. The earliest I can probably get to this for review would be tomorrow morning (8/14 in the AM PDT) as my calendar has me fully booked with meetings most of today. Thanks, - Alex