On Thu, Aug 08, 2024 at 02:20:21PM -0600, Shuah Khan wrote: > Wouldn't make sense to fix fix this in selftests main Makefile > instead of changing the all the test makefiles As of now, the usage of rpath is localised, so it is relatively easy to evaluate the effect/prudence of such a change; I am not so confident in imposing rpath on all of the selftests (and, if doing so, I would rather opt for runpath, to leave out an ability to override the search path via LD_LIBRARY_PATH, if such need arises); in that case it is possibly also worth to add -L$(OUTPUT) to the CFLAGS as well, as the compile-time counterpart. But, again, I was trying to avoid the task of evaluating the possible side effects of such a change, considering the variability in environments and setups selftests are run. > Same comment on all other files. > It would be easier to send these as series I hesitated to do so due to the fact that different selftests are seemingly maintained by different people. > please mentioned the tests run as well after this change. I have checked the ldd output after the change remained the same (and that ldd is able to find the libraries used when run outside the directory the tests reside in) and did a cursory check of the results of the run of the affected tests (but not so sure about the BPF selftests, as they don't compile as-is due to numerous "incompatible pointer types" warnings that are forced into errors by -Werror and the fact that it hanged the machine I tried to run them on). > thanks, > -- Shuah > >
