On 12/16/19 9:36 PM, Andrii Nakryiko wrote:
> Add bpftool-gen.rst describing skeleton on the high level. Also include
> a small, but complete, example BPF app (BPF side, userspace side, generated
> skeleton) in example section to demonstrate skeleton API and its usage.
>
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
When applying the patch locally (git apply <>), I see below:
-bash-4.4$ git apply ~/p3.txt
/home/yhs/p3.txt:183: trailing whitespace.
/home/yhs/p3.txt:187: trailing whitespace.
/home/yhs/p3.txt:189: space before tab in indent.
__uint(type, BPF_MAP_TYPE_HASH);
/home/yhs/p3.txt:190: space before tab in indent.
__uint(max_entries, 128);
/home/yhs/p3.txt:191: space before tab in indent.
__type(key, int);
warning: squelched 77 whitespace errors
warning: 82 lines add whitespace errors.
-bash-4.4$
space before tab might be fine since it is an code in the example file.
But tailing whitespaces probably should be fixed.
With the above in mind,
Acked-by: Yonghong Song <yhs@xxxxxx>
