On Fri, Aug 02, 2024 at 11:46:41AM GMT, Russell King (Oracle) wrote: > Discussing with Serge Semin, it appears that the GMAC_ANE_ADV and > GMAC_ANE_LPA registers are only available for TBI and RTBI PHY > interfaces. In commit 482b3c3ba757 ("net: stmmac: Drop TBI/RTBI PCS > flags") support for these was dropped, and thus it no longer makes > sense to access these registers. > > Remove the *_get_adv_lp() functions from the stmmac driver. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> Clean up seems good, I'll take Serge's word on the IP details here. Reviewed-by: Andrew Halaney <ahalaney@xxxxxxxxxx>