On Thu, Aug 01, 2024 at 08:18:21PM -0700, jitendra.vegiraju@xxxxxxxxxxxx wrote: > +static u32 stmmac_get_user_version(struct stmmac_priv *priv, u32 id_reg) > +{ > + u32 reg = readl(priv->ioaddr + id_reg); > + > + if (!reg) { > + dev_info(priv->device, "User Version not available\n"); > + return 0x0; > + } > + > + return (reg & GENMASK(23, 16)) >> 16; return FIELD_GET(GENMASK(23, 16), reg); For even more bonus points, use a #define for the field mask. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!