On Thu, Jul 25, 2024 at 12:06:22PM +0200, Daniel Borkmann wrote:
> On 7/24/24 5:23 PM, Maciej Fijalkowski wrote:
> > On Fri, Jul 12, 2024 at 06:52:50PM -0700, Stanislav Fomichev wrote:
> > > Julian reports that commit 341ac980eab9 ("xsk: Support tx_metadata_len")
> > > can break existing use cases which don't zero-initialize xdp_umem_reg
> > > padding. Fix it (while still breaking a minority of new users of tx
> > > metadata), update the docs, update the selftest and sprinkle some
> > > BUILD_BUG_ONs to hopefully catch similar issues in the future.
> > >
> > > Thank you Julian for the report and for helping to chase it down!
> > >
> > > Reported-by: Julian Schindel <mail@xxxxxxxxxxxxxxxx>
> > > Cc: Magnus Karlsson <magnus.karlsson@xxxxxxxxx>
> >
> > For the content series,
> >
> > Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> >
> > However I was not sure about handling patch 3/3.
>
> Ok, then I'm taking in the first two for now as they seem to actually
> address the fix and the 3rd seems like an improvement which could also
> get routed via bpf-next. In either case, if one of you could follow-up
> on the latter, that would be great.
My first thought was about squashing 1 and 3 but I hope Stan doesn't mind
sending 3 solely to bpf-next...
>
> Thanks,
> Daniel
