On Friday, July 19th, 2024 at 11:18 AM, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: [...] > Note [test_maps] for all three variants (I expected > test_maps/test_progs + no_alu32 + cpuv4, just like we see for skel.h). > Can you please double check what's going on? Looking at timestamps it > seems like they are actually regenerated, though. Yeah, this is weird. Will look into it. > BTW, if you get a chance, see if you can avoid unnecessary EXT-COPY as > well (probably a bit smarter rule dependency should be set up, e.g., > phony target that then depends on actual files or something like > that). > > Regardless, this is a massive improvement and seems to work correctly, > so I've applied this and will wait for follow ups. Thanks a lot! You're welcome! Happy to see my first patch accepted! > > BTW, are you planning to look into vmlinux.h optimization as well? Yes, it seems there is more room for improvements. I think making changes like this patch is a great way to get familiar with the codebase, which is what I'm trying to do. Even better if the changes are actually useful :)
