On Wed, Jul 17, 2024 at 3:13 AM Donald Hunter <donald.hunter@xxxxxxxxx> wrote: > > Amery Hung <ameryhung@xxxxxxxxx> writes: > > > Hi all, > > > > This patchset aims to support implementing qdisc using bpf struct_ops. > > This version takes a step back and only implements the minimum support > > for bpf qdisc. 1) support of adding skb to bpf_list and bpf_rbtree > > directly and 2) classful qdisc are deferred to future patchsets. > > How do you build with this patchset? > > I had to build with the following to get the selftests to build: > > CONFIG_NET_SCH_NETEM=y > CONFIG_NET_FOU=y > There are config issues in my code. bpf qdisc depends on CONFIG_NET_SCHED. Therefore, I will create a config entry, CONFIG_NET_SCH_BPF, for bpf qdisc and make it under CONFIG_NET_SCHED in Kconfig. The selftests will then require CONFIG_NET_SCH_BPF to build. I will send the fixed patches in reply to the problematic patches. Sorry for the inconvenience. > > * Miscellaneous notes * > > > > The bpf qdiscs in selftest requires support of exchanging kptr into > > allocated objects (local kptr), which Dave Marchevsky developed and > > kindly sent me as off-list patchset. > > It's impossible to try out this patchset without the kptr patches. Can > you include those patches here? Will do.