Re: [bpf-next v3 02/12] bpf: no_caller_saved_registers attribute for helper calls

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Mon, Jul 15, 2024 at 4:02 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> @@ -21771,6 +22058,12 @@ int bpf_check(struct bpf_prog **prog, union bpf_attr *attr, bpfptr_t uattr, __u3
>         if (ret == 0)
>                 ret = check_max_stack_depth(env);
>
> +       /* might decrease stack depth, keep it before passes that
> +        * allocate additional slots.
> +        */
> +       if (ret == 0)
> +               ret = remove_nocsr_spills_fills(env);

Probably should be before check_max_stack_depth() above :)