On Fri, 2024-07-12 at 12:20 -0700, Andrii Nakryiko wrote: [...] > > An alternative fix would be to specify additional dependencies for > > core_reloc.test.o (and others) directly, e.g.: > > > > core_reloc.test.o: test_core_reloc_module.bpf.o ... > > > > (with correct trunner prefix) > > I was about to say that not all tests use BPF skeleton headers just > yet, so we have to have a way to explicitly specify dependencies. I > think a separate list should be good enough for now, and in parallel > we should try to switch remaining tests to skeleton headers. Even if > we don't want to convert tests themselves to using skeleton structs, > we can convert them to use elf_bytes from skeleton headers instead of > loading .bpf.o files from disk. That should eliminate the need for > extra dependencies. For the scope of this patch-set, I'd say specifying dependencies in the Makefile should be ok. Or would you prefer migrating tests to use elf bytes? [...]
