Re: [RFC bpf-next v2 2/9] bpf: no_caller_saved_registers attribute for helper calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2024-07-09 at 18:09 -0700, Alexei Starovoitov wrote:

[...]


> somewhere after spill/fill removal subprog->stack_depth
> needs to be adjust to nocsr_stack_off,
> otherwise extra stack space is wasted.
> I couldn't find this logic in the patch.

Such logic is not present.

> Once the adjustment logic is done, pls add a selftest with
> nocsr and may_goto, since may_goto processing is in the same
> do_misc_fixups() loop and it needs to grow the stack while
> spill/fill removal will shrink the stack.

It might be necessary to move the spill/fill removal to a separate
pass exactly because of this dependency.

I'll think about the implementation, but it might be tricky.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux